This is a snapshot of Indico's old Trac site. Any information contained herein is most probably outdated. Access our new GitHub site here.

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#402 closed defect (fixed)

Error creating booking - possible input validation issue

Reported by: pferreir Owned by: irolewic
Priority: high Milestone: v0.97.0
Component: General Version: 0.97.0
Keywords: Cc:

Description

We are receiving an error that seems to stem from improper input validation.

--------------------
User Comments




--------------------
Error details

exception message => list index out of range
exception type => exceptions.IndexError
traceback => 
  File "/usr/lib/python2.4/site-packages/cds_indico-0.97b2-py2.4.egg/MaKaC/webinterface/rh/base.py", line 462, in process
    self._checkParams( self._reqParams )

  File "/usr/lib/python2.4/site-packages/cds_indico-0.97b2-py2.4.egg/MaKaC/webinterface/rh/roomBooking.py", line 1022, in _checkParams
    candResv = self._loadResvCandidateFromParams( None, params )

  File "/usr/lib/python2.4/site-packages/cds_indico-0.97b2-py2.4.egg/MaKaC/webinterface/rh/roomBooking.py", line 413, in _loadResvCandidateFromParams
    self._checkParamsRepeatingPeriod( params )

  File "/usr/lib/python2.4/site-packages/cds_indico-0.97b2-py2.4.egg/MaKaC/webinterface/rh/roomBooking.py", line 127, in _checkParamsRepeatingPeriod
    sMinute = int( t[1] )

request handler => <class 'MaKaC.webinterface.rh.roomBooking.RHRoomBookingBookingForm'>
url => http://indico.cern.ch/roomBooking.py/bookingForm?roomLocation=CERN&roomID=100

Change History (4)

comment:1 Changed 5 years ago by irolewic

  • Owner set to irolewic
  • Status changed from new to accepted

comment:2 Changed 5 years ago by ian.rolewicz@…

  • Resolution set to fixed
  • Status changed from accepted to closed

commit f25ab48c53175c458765a5be5f6aaba1337cfec6
Author: Ian Rolewicz <ian.rolewicz@…>
Date: Fri May 21 08:47:56 2010 +0200

[FIX] Error on booking creation


  • fixes #402
  • Added additional format checking on the server side to prevent users from getting this problem.
  • We suppose the users were using the Enter key to submit the form, which happened to bypass the validity checking of the fields
  • JavaScript? was added to handle the case when a key is pressed
  • Other forms in the code were checked in order to see if any of them was submitted the same way, but none was find.

comment:3 Changed 5 years ago by Ian Rolewicz <ian.rolewicz@…>

In [f25ab48c53175c458765a5be5f6aaba1337cfec6]:

[FIX] Error on booking creation

  • fixes #402
  • Added additional format checking on the server side to prevent users from getting this problem.
  • We suppose the users were using the Enter key to submit the form, which happened to bypass the validity checking of the fields
  • JavaScript? was added to handle the case when a key is pressed
  • Other forms in the code were checked in order to see if any of them was submitted the same way, but none was find.

comment:4 Changed 5 years ago by Ian Rolewicz <ian.rolewicz@…>

In [f25ab48c53175c458765a5be5f6aaba1337cfec6]:

[FIX] Error on booking creation

  • fixes #402
  • Added additional format checking on the server side to prevent users from getting this problem.
  • We suppose the users were using the Enter key to submit the form, which happened to bypass the validity checking of the fields
  • JavaScript? was added to handle the case when a key is pressed
  • Other forms in the code were checked in order to see if any of them was submitted the same way, but none was find.
Note: See TracTickets for help on using tickets.