This is a snapshot of Indico's old Trac site. Any information contained herein is most probably outdated. Access our new GitHub site here.

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#401 closed defect (fixed)

Protect var.js.tpl from a not set DefaultLocation

Reported by: dgalimbe Owned by: irolewic
Priority: normal Milestone: v0.97.0
Component: Installation Version: 0.97.0
Keywords: Cc:

Description

vars.js.tpl:136
DefaultLocation?: '<%= str(Location.getDefaultLocation().friendlyName) %>',

if Location.getDefaultLocation() == None don't load the friendlyName

Change History (5)

comment:1 Changed 5 years ago by dgalimbe

  • Owner set to dgalimbe
  • Status changed from new to accepted

comment:2 Changed 5 years ago by irolewic

  • Owner changed from dgalimbe to irolewic
  • Status changed from accepted to assigned

Seems to be the same as ​http://cdswaredev.cern.ch/indico/ticket/345

comment:3 Changed 5 years ago by irolewic

  • Status changed from assigned to accepted

comment:4 Changed 5 years ago by ian.rolewicz@…

  • Resolution set to fixed
  • Status changed from accepted to closed

commit 36827b1a86042c91cf604c1f302e95e153475469
Author: Ian Rolewicz <ian.rolewicz@…>
Date: Fri May 21 16:22:21 2010 +0200

[FIX] Empty Default Location causes an error


  • fixes #401
  • fixes #345
  • vars.js.tpl was trying to get Location.getDefaultLocation().friendlyName, but failed generating vars.js.tpl.tmp since Location.getDefaultLocation() returned None. Added if-statements to get an empty string as a default location if the latter was None.

comment:6 Changed 5 years ago by Ian Rolewicz <ian.rolewicz@…>

In [36827b1a86042c91cf604c1f302e95e153475469]:

[FIX] Empty Default Location causes an error

  • fixes #401
  • fixes #345
  • vars.js.tpl was trying to get Location.getDefaultLocation().friendlyName, but failed generating vars.js.tpl.tmp since Location.getDefaultLocation() returned None. Added if-statements to get an empty string as a default location if the latter was None.
Note: See TracTickets for help on using tickets.