This is a snapshot of Indico's old Trac site. Any information contained herein is most probably outdated. Access our new GitHub site here.

Opened 4 years ago

Closed 3 years ago

#910 closed defect (fixed)

Remove all the infoMsg and errorMsg from the code

Reported by: jbenito Owned by: jatrzask
Priority: high Milestone: v0.99.0
Component: General Version:
Keywords: Cc:

Description (last modified by pferreir)


Change History (11)

comment:1 Changed 3 years ago by jbenito

  • Milestone changed from v0.98.1 to v0.99.1
  • Owner set to jatrzask
  • Status changed from new to assigned

comment:2 Changed 3 years ago by jbenito

  • Milestone changed from v0.99.1 to v0.99.0

comment:3 Changed 3 years ago by jatrzask

  • Status changed from assigned to in_work

comment:4 Changed 3 years ago by jatrzask

  • Status changed from in_work to awaiting_merge

comment:5 Changed 3 years ago by pferreir

  • Status changed from awaiting_merge to merging

comment:6 Changed 3 years ago by pferreir

  • Description modified (diff)

comment:7 Changed 3 years ago by pferreir

  • Description modified (diff)

I've actually gone back on the error message for abstract merging/duplicates, as they should still be displayed. I made them look a bit nicer though. Code available on my 910-fix-remove-all-infoMsg-and-errorMsg branch.

There are however, some improvements that could be done on this commit:

  • All the code that is added/moved could be PEP8-compliant. I noticed that there are quite some spaces missing around operators;
  • Is AddNewMaterial.tpl and related code really still used? If not, we should just delete it;
  • There are some changes related to WPModSlotEdit, WPModSlotNew, which I doubt that we still use. It would be nice removing this and any related code that we may still have;
  • Is the abstractMgr parameter that gets passed to WConfModAbstractsMerge really needed?

comment:8 Changed 3 years ago by pferreir

  • Status changed from merging to assigned

comment:9 Changed 3 years ago by jatrzask

  • Status changed from assigned to in_work

comment:10 Changed 3 years ago by jatrzask

  • Status changed from in_work to awaiting_merge

comment:11 Changed 3 years ago by Jakub Trzaskoma <jakub.piotr.trzaskoma@…>

  • Resolution set to fixed
  • Status changed from awaiting_merge to closed

In e2c2addbf6d048665cb99beef9113fb319d7abae/indico:

[FIX] Removed all errorMsg and add client side validation instead

  • removed all errorMsg, errorList etc. and all related components
  • moved error messages from error lists to NoReportError? exceptions
  • added js form validation on the client side (marked mandatory fields)
  • closes #910
Note: See TracTickets for help on using tickets.