This is a snapshot of Indico's old Trac site. Any information contained herein is most probably outdated. Access our new GitHub site here.

Opened 6 years ago

Closed 5 years ago

Last modified 5 years ago

#28 closed defect (fixed)

Sometimes resvId is None and we get an exception

Reported by: jbenito Owned by: jbenito
Priority: low Milestone: v0.97.0
Component: Room Booking Version: 0.97.0
Keywords: Cc:

Description (last modified by pferreir)

User Comments

I am trying to book a conference room and I continue to receive a "invalid literal for int(): None."

Thanks.

Error details

exception message => invalid literal for int(): None
exception type => exceptions.ValueError
traceback => 
  File "/usr/lib/python2.4/site-packages/MaKaC/webinterface/rh/base.py", line 431, in process
    self._checkParams( self._reqParams )

  File "/usr/lib/python2.4/site-packages/MaKaC/webinterface/rh/conferenceModif.py", line 7411, in _checkParams
    RHRoomBookingBookingDetails._checkParams( self, params )

  File "/usr/lib/python2.4/site-packages/MaKaC/webinterface/rh/roomBooking.py", line 940, in _checkParams
    locator.setRoomBooking( params )

  File "/usr/lib/python2.4/site-packages/MaKaC/webinterface/locators.py", line 281, in setRoomBooking
    self.__resvID = int( params['resvID'] )

request handler => <class 'MaKaC.webinterface.rh.conferenceModif.RHConfModifRoomBookingDetails'>
url => http://indicobeta.cern.ch/conferenceModification.py/roomBookingDetails?roomLocation=CERN&resvID=None&confId=73528
parameters => 
roomLocation = CERN
resvID = None
confId = 73528
headers => 
Host: indicobeta.cern.ch

Change History (12)

comment:1 Changed 6 years ago by jbenito

  • Description modified (diff)

comment:2 Changed 6 years ago by pferreir

  • Description modified (diff)

comment:3 Changed 6 years ago by cemunoz

  • Owner set to cemunoz
  • Status changed from new to accepted

comment:4 Changed 6 years ago by cemunoz

Probably, the error comes from the file roomBooking.py, in the function _checkParams of the class RHRoomBookingBookingForm, in which the None value is assigned to resvID in some cases.
The None value appears (at least) when you clone a conference and you book another date, altough the URL is not the same that appears in the tracebacks provided. Therefore, there must be probably another way to get the None value for the resvID.

comment:5 Changed 6 years ago by pferreir

  • Priority changed from major to minor

comment:6 Changed 5 years ago by jbenito

  • Owner cemunoz deleted
  • Status changed from in_work to new

This happens when pre-bookings collide!

comment:7 Changed 5 years ago by jbenito

  • Owner set to jbenito
  • Status changed from new to assigned

comment:8 Changed 5 years ago by jbenito

  • Status changed from assigned to in_work

comment:9 Changed 5 years ago by jbenito

  • Status changed from in_work to in_merge

This happens when pre-bookings collide!

comment:10 Changed 5 years ago by Jose Benito <jose.benito.gonzalez@…>

  • Resolution set to fixed
  • Status changed from in_merge to closed

In [fbe91854937ee650b3b0ff1368e3ab3395fd61f0]:

[FIX] Missing RB interface for conferences

  • When PRE-bookings where conflicting, there was a missing page (within Conferences) to confirm the PRE-booking.
  • fixes #28

comment:11 Changed 5 years ago by Jose Benito <jose.benito.gonzalez@…>

In [fbe91854937ee650b3b0ff1368e3ab3395fd61f0]:

[FIX] Missing RB interface for conferences

  • When PRE-bookings where conflicting, there was a missing page (within Conferences) to confirm the PRE-booking.
  • fixes #28

comment:12 Changed 5 years ago by Jose Benito <jose.benito.gonzalez@…>

In [fbe91854937ee650b3b0ff1368e3ab3395fd61f0]:

[FIX] Missing RB interface for conferences

  • When PRE-bookings where conflicting, there was a missing page (within Conferences) to confirm the PRE-booking.
  • fixes #28
Note: See TracTickets for help on using tickets.