This is a snapshot of Indico's old Trac site. Any information contained herein is most probably outdated. Access our new GitHub site here.

Opened 6 years ago

Closed 6 years ago

Last modified 5 years ago

#235 closed defect (fixed)

"Enter" key problem with 2 dialogs and IE8

Reported by: dmartinc Owned by: pferreir
Priority: normal Milestone: v0.97.0
Component: General Version: 0.97.0
Keywords: IE, timetable, dialog Cc:

Description

How to reproduce:

-With IE8, create a meeting, go to timetable, add new->session (or contribution).
-Click in the "title" field. Write a name. Click on the "add existing" button to add a convener / presenter. Write something in one of the user search dialog's fields, and press the Enter key to launch the search.
-The search should be launched, but the Enter key also activates the "Add" button of the first dialog (session / contribution creation). Therefore the session / contribution is added to the timetable without the convener / presenter and the user search dialog is still "floating" over the page.

Note: observe that in IE8, the "Add" button starts with some kind of shading that seems to indicate it has focus. It loses the shading when clicking on "Add Existing" but that does not stop it from being pressed with the "Enter" key.

I could reproduce with indicows 's IE8 (version 8.0.6001.18702CO) but not with cernts.cern.ch's IE7, where this works fine.

Change History (8)

comment:1 Changed 6 years ago by jose.pedro.ferreira@…

  • Resolution set to fixed
  • Status changed from new to closed

commit 77705eba78436b491743b49c60d0c44bf8cfd5fb
Author: Pedro Ferreira <jose.pedro.ferreira@…>
Date: Thu Mar 18 15:27:25 2010 +0100

[FIX] Problem with "enter" key


  • apparently a bubbling issue;
  • fixes #235;

comment:2 Changed 6 years ago by pferreir

  • Resolution fixed deleted
  • Status changed from closed to reopened

comment:3 Changed 6 years ago by pferreir

  • Owner set to pferreir
  • Status changed from reopened to accepted

comment:4 Changed 6 years ago by pferreir

  • Resolution set to fixed
  • Status changed from accepted to closed

comment:5 Changed 6 years ago by pferreir

  • Resolution fixed deleted
  • Status changed from closed to reopened

comment:6 Changed 6 years ago by jose.pedro.ferreira@…

  • Resolution set to fixed
  • Status changed from reopened to closed

commit 85f7490a485e5aae312fbc22e2a96946d4825e0a
Author: Pedro Ferreira <jose.pedro.ferreira@…>
Date: Thu Mar 18 18:59:37 2010 +0100

[FIX] Several JS/Layout fixes


  • Regexp for URL was too restrictive;
  • Replaced every occurrence of Html.button() with Html.input('text') - thanks to IE - in order to fix #235 (the last fix was not complete - thanks David);
  • Improved a bit the aesthetics of the "visibility panel" in the Material editor dialog - added "disabled" opacity hint;
  • Changed the color code for warnings (following a change in the style guide);

comment:7 Changed 5 years ago by Pedro Ferreira <jose.pedro.ferreira@…>

In [77705eba78436b491743b49c60d0c44bf8cfd5fb]:

[FIX] Problem with "enter" key

  • apparently a bubbling issue;
  • fixes #235;

comment:8 Changed 5 years ago by Pedro Ferreira <jose.pedro.ferreira@…>

In [85f7490a485e5aae312fbc22e2a96946d4825e0a]:

[FIX] Several JS/Layout fixes

  • Regexp for URL was too restrictive;
  • Replaced every occurrence of Html.button() with Html.input('text') - thanks to IE - in order to fix #235 (the last fix was not complete - thanks David);
  • Improved a bit the aesthetics of the "visibility panel" in the Material editor dialog - added "disabled" opacity hint;
  • Changed the color code for warnings (following a change in the style guide);
Note: See TracTickets for help on using tickets.