This is a snapshot of Indico's old Trac site. Any information contained herein is most probably outdated. Access our new GitHub site here.

Opened 6 years ago

Closed 5 years ago

Last modified 5 years ago

#213 closed enhancement (fixed)

Synchronize favourite icons

Reported by: dmartinc Owned by: dmartinc
Priority: very low Milestone:
Component: General Version: 0.97.0
Keywords: favourites Cc:

Description

When a user appears in several parts of a page (or a dialog, etc.) with a active / non active "favourite" icon next to him, clicking on one of the icons should also change the other.
Also if a user is added / removed from the favourites this way, and the user is added later to some part of a page, the new favourite icon should be in the correct state.
We could do this by including a list of the user's favourite users' ids in every page (or just those needed, via a boolean flag in the WPBase class).
Then, when "add to favourite" widgets are created, they look into this list and they add a boolean WatchValue? to a dictionary (that starts empty on page load, and whose keys are user ids) and they bind to it. If the corresponding WatchValue? is already in the dictionary (because another widget for the same user already added it), the widget just binds to the existing WatchValue?.
Then, when the user clicks on the widget to add / remove a favourite, if the answer from the server is positive, the WatchValue? is changed and all of the widgets binded to that WatchValue? will change.

Change History (4)

comment:1 Changed 6 years ago by dmartinc

  • Status changed from new to accepted

comment:2 Changed 6 years ago by jbenito

  • Priority changed from normal to very low

comment:3 Changed 5 years ago by david.martin.clavo@…

  • Resolution set to fixed
  • Status changed from accepted to closed

commit b1285c7a142938e0bb83557fcfe43b4ea2cadf69
Author: David Martín Clavo <david.martin.clavo@…>
Date: Tue Mar 23 13:49:09 2010 +0100

[IMP] New Users.js


-New FavouritizeButton? that is aware
of other buttons.
-New ChooseUsersPopup? to replace
SearchUsersPopup?.
-New NewUsersListField? to replace
UsersListField?.
-New SingleUserField?.
-Removed unused StaticUserListField?
-Commented out unused classes in Users.js
-fixes #187
-fixes #212
-fixes #213

comment:3 Changed 5 years ago by David Martín Clavo <david.martin.clavo@…>

In [b1285c7a142938e0bb83557fcfe43b4ea2cadf69]:

[IMP] New Users.js

-New FavouritizeButton? that is aware
of other buttons.
-New ChooseUsersPopup? to replace
SearchUsersPopup?.
-New NewUsersListField? to replace
UsersListField?.
-New SingleUserField?.
-Removed unused StaticUserListField?
-Commented out unused classes in Users.js
-fixes #187
-fixes #212
-fixes #213

Note: See TracTickets for help on using tickets.