This is a snapshot of Indico's old Trac site. Any information contained herein is most probably outdated. Access our new GitHub site here.

Opened 6 years ago

Closed 5 years ago

Last modified 5 years ago

#186 closed defect (fixed)

JS Error in Video Services Overview page with some versions of IE8

Reported by: dmartinc Owned by: dmartinc
Priority: low Milestone: v0.97.0
Component: Video Services Version: 0.97.0
Keywords: js, ie8, collaboration Cc:

Description

"http://indicobeta.cern.ch/adminCollaboration.py clicking on recording request or other buttons triggers a js error and the page does not change. (IE 8)"

There's a JS error when clicking on index name titles such as "all", "EVO", etc.

This happens with Thomas's IE8, but I could not reproduce it with other IE8's (Ian, Cveti, Joao, virtual machines...).
I tried to remove Pedro's recent fix with forces IE8 to ignore the compatibility view rules, in order to load the page in compatibility view, but I still cannot reproduce the error.

Copy/paste of the IE JS error report (not very helpful...):

Webpage error details

 

User Agent: Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 6.0; Trident/4.0; SLCC1; .NET CLR 2.0.50727; InfoPath.2; .NET CLR 3.0.30729; .NET CLR 3.5.30729)

Timestamp: Fri, 12 Feb 2010 16:58:40 UTC

 

 

Message: Expected ')'

Line: 1868

Char: 63

Code: 0

URI: http://indicobeta.cern.ch/adminCollaboration.py

 

 

Message: Object expected

Line: 1348

Char: 1

Code: 0

URI: http://indicobeta.cern.ch/adminCollaboration.py

 

 

Message: Object expected

Line: 1356

Char: 1

Code: 0

URI: http://indicobeta.cern.ch/adminCollaboration.py

 

 

Message: Object expected

Line: 1364

Char: 1

Code: 0

URI: http://indicobeta.cern.ch/adminCollaboration.py

 

 

Message: Object expected

Line: 1356

Char: 1

Code: 0

URI: http://indicobeta.cern.ch/adminCollaboration.py

 

 

Message: Object expected

Line: 1348

Char: 1

Code: 0

URI: http://indicobeta.cern.ch/adminCollaboration.py

 

 

Message: Object expected

Line: 1324

Char: 1

Code: 0

URI: http://indicobeta.cern.ch/adminCollaboration.py

If the lines numbers make reference to the html file (and not any linked JS file which are packed and dont have a lot of lines), line 1868 is:

var cell = Html.td('ACBookingCell', Html.span('', 'In event: '), Html.span('', booking.conference.title));

lines 1324, 1348, 1364, etc. are all similar to:

<a id="index_all" onclick="indexSelectedObs('all', false)" class="CAIndexUnselected"  >

(they are the links with the index name, they all call the same function on onclick)

Change History (3)

comment:1 Changed 6 years ago by dmartinc

  • Milestone set to v0.97
  • Owner set to dmartinc
  • Status changed from new to accepted

It seems this is not a JS issue but a translation issue; the page works in English but not in French.

comment:2 Changed 5 years ago by david.martin.clavo@…

  • Resolution set to fixed
  • Status changed from accepted to closed

commit 002f2a8e8670053f0d479279de1bcd5a3f287149
Author: David Martín Clavo <david.martin.clavo@…>
Date: Thu Mar 25 13:49:53 2010 +0100

[FIX] VSOverview page problems in French


-There was a Python's _ i18n function
being used inside a Javascript string;
the english string was 'In event' and
was being replaced by 'Dans l'évènenement',
therefore provoking a syntax error.
-Replaced <%= _() %> by $T() in Javascript code.
-Added some missing <%= _() %> in HTML code.

  • fixes #186
  • reviewed by jbenito: missing $T.

comment:3 Changed 5 years ago by David Martín Clavo <david.martin.clavo@…>

In [002f2a8e8670053f0d479279de1bcd5a3f287149]:

[FIX] VSOverview page problems in French

-There was a Python's _ i18n function
being used inside a Javascript string;
the english string was 'In event' and
was being replaced by 'Dans l'évènenement',
therefore provoking a syntax error.
-Replaced <%= _() %> by $T() in Javascript code.
-Added some missing <%= _() %> in HTML code.

  • fixes #186
  • reviewed by jbenito: missing $T.
Note: See TracTickets for help on using tickets.