This is a snapshot of Indico's old Trac site. Any information contained herein is most probably outdated. Access our new GitHub site here.

Opened 6 years ago

Closed 6 years ago

Last modified 5 years ago

#182 closed defect (fixed)

Remove favourite does not work from principal table

Reported by: dmartinc Owned by: pferreir
Priority: normal Milestone: v0.97.0
Component: General Version: 0.97.0
Keywords: favourites Cc:

Description

Removing a favourite works well from a user's personal area.
However it does not when clicking on an "illuminated" star icon:

Service request failed. Request text:
{"version":"1.1","method":"user.favorites.removeUser","params":{"value":[{"id":"2562"}]}}

Traceback (most recent call last):
  File "/usr/lib/python2.4/site-packages/cds_indico-0.97b2-py2.4.egg/MaKaC/services/interface/rpc/json.py", line 106, in process
    result = invokeMethod(str(requestBody["method"]), requestBody.get("params", []), req)
  File "/usr/lib/python2.4/site-packages/cds_indico-0.97b2-py2.4.egg/MaKaC/services/interface/rpc/process.py", line 86, in invokeMethod
    raise ProcessError("ERR-P0", "Error processing method.")
ProcessError: ERR-P0 : Error processing method.

Inner Exception:
Traceback (most recent call last):

  File "/usr/lib/python2.4/site-packages/cds_indico-0.97b2-py2.4.egg/MaKaC/services/interface/rpc/process.py", line 67, in invokeMethod
    result = processRequest(method, params, req)

  File "/usr/lib/python2.4/site-packages/cds_indico-0.97b2-py2.4.egg/MaKaC/services/interface/rpc/process.py", line 45, in processRequest
    result = handler(params, req.get_remote_host(), getSession(req)).process()

  File "/usr/lib/python2.4/site-packages/cds_indico-0.97b2-py2.4.egg/MaKaC/services/implementation/base.py", line 222, in process
    self._checkParams()

  File "/usr/lib/python2.4/site-packages/cds_indico-0.97b2-py2.4.egg/MaKaC/services/implementation/user.py", line 93, in _checkParams
    self._obj = user.AvatarHolder().getById(self._params['id'])

KeyError: 'id'

Change History (6)

comment:1 Changed 6 years ago by pferreir

  • Milestone set to v0.97
  • Owner changed from dmartinc to pferreir
  • Status changed from new to accepted

comment:2 Changed 6 years ago by jose.pedro.ferreira@…

  • Resolution set to fixed
  • Status changed from accepted to closed

commit d0a51f58673028c0a3234b0979755dc7383d8684
Author: Pedro Ferreira <jose.pedro.ferreira@…>
Date: Thu Feb 11 17:25:05 2010 +0100

[FIX] Removing users from favorites


comment:3 Changed 6 years ago by dmartinc

  • Resolution fixed deleted
  • Status changed from closed to reopened

Testing in my PC, looks like the star widget now works to remove a favourite, but now removing it from the user's personal area throws an exception.
It seems both widgets are sending the id in a different way; one directly as "id", the other inside a "value"; so we have to make them do the same thing...

comment:4 Changed 6 years ago by jose.pedro.ferreira@…

  • Resolution set to fixed
  • Status changed from reopened to closed

commit 3422580b3676f103c6dd67c528d8d2c615221305
Author: Pedro Ferreira <jose.pedro.ferreira@…>
Date: Tue Feb 16 15:17:56 2010 +0100

[FIX] Problem removing users in 'favorites' dialog


  • fixes #182 once and for all (i hope);

comment:5 Changed 5 years ago by Pedro Ferreira <jose.pedro.ferreira@…>

In [d0a51f58673028c0a3234b0979755dc7383d8684]:

[FIX] Removing users from favorites

comment:6 Changed 5 years ago by Pedro Ferreira <jose.pedro.ferreira@…>

In [3422580b3676f103c6dd67c528d8d2c615221305]:

[FIX] Problem removing users in 'favorites' dialog

  • fixes #182 once and for all (i hope);
Note: See TracTickets for help on using tickets.