Electronic Agreement - CC + FROM

[jbenito]

2 improvements:

1. Allow to CC (by default the logged person) when sending email to authors.
2. FROM address is showing wrong information (it shouldn't say Indico Mailer all the time).

[jbenito]

3. Send email to organizer when authors sign (or not) the agreement (also with a checkbox?)

[arescope]

We need to discuss the last commit when integrating.

[pferreir]

Several things to discuss here.

FIrst of all, the changes/fixes I suggest:
http://indico-software.org/repo/personal/indico-pferreir/commit/?h=980-imp-electronic-agreement&id=05bc156f88361473051777967fa9e90eec7f2014

Comments:

• IDs in the mail subject - is this supposed to be user-friendly? Or is it for some other reason? (do managers need the ID?);
• Added conference URL to e-mail - it is more useful and contains the ID in case people need it;
• Used format() function for string formatting;
• Added _() around messages, but still need to find a way to make the text be put in the dictionary - perhaps using the N_ placeholder?
• The checkbox was unchecked by default... actually, does the checkbox make sense at all? Do we want speakers to be able to silently accept the agreement, thus keeping organizers in the dark? If it does, then I think it should be checked by default (yes, like an annoying newsletter);
• I fixed an error due to the fact that the full avatar was being passed as an address in the notification. Was this tested?

[pferreir]

After discussing the original request with Jose, we got to the conclusion that the implementation of point 3 that this patch suggests differs from the original intent. The speaker shouldn't be the one deciding about the notification - it should be the event creator/manager deciding whether (s)he wants to receive notifications or not. There has been some misunderstanding.

[jbenito]

commit: bd6fbebaaa1d8363f0b1975b9352ac87d8451fc0