Opened 4 years ago
Closed 3 years ago
#918 closed defect (fixed)
Incorrect return value check in TextIndex.unindex
Reported by: | morrison | Owned by: | |
---|---|---|---|
Priority: | blocker | Milestone: | v0.98.2 |
Component: | General | Version: | |
Keywords: | Cc: |
Description
When you add a Category to a fresh install of Indico (as happens with the migration script), you run into a bug in TextIndex? that prevents you from proceeding. This line: https://indico-software.org/browser/indico/indico/MaKaC/common/indexes.py#L1206 checks whether IntStringMappedIndex?.getInteger has returned 0. The problem is that 0 is a legitimate value in the TextIndex? hash. If the index isn't found, getIndex returns None. I believe the line should read instead:
if intId != None:
Change History (2)
comment:1 Changed 3 years ago by jbenito
- Milestone changed from v0.98.1 to v0.99.0
- Priority changed from normal to blocker
comment:2 Changed 3 years ago by jbenito
- Milestone changed from v0.99.0 to v0.98.2
- Resolution set to fixed
- Status changed from new to closed
Note: See
TracTickets for help on using
tickets.