NoReportError from invalid values in room map time filter allows reporting

[jmonnich]

ERR-P0
Error processing method.
Inner error: ['Traceback (most recent call last):\n', '  File "/usr/lib/python2.6/site-packages/indico-0.98_dev-py2.6.egg/MaKaC/services/interface/rpc/process.py", line 85, in invokeMethod\n    result = processRequest(method, copy.deepcopy(params), req)\n', '  File "/usr/lib/python2.6/site-packages/indico-0.98_dev-py2.6.egg/MaKaC/services/interface/rpc/process.py", line 53, in processRequest\n    result = handler(params, getSession(req), req).process()\n', '  File "/usr/lib/python2.6/site-packages/indico-0.98_dev-py2.6.egg/MaKaC/services/implementation/base.py", line 229, in process\n    self._checkParams()\n', '  File "/usr/lib/python2.6/site-packages/indico-0.98_dev-py2.6.egg/MaKaC/services/implementation/roomBooking.py", line 88, in _checkParams\n    self._checkParamsRepeatingPeriod(self._params)\n', '  File "/usr/lib/python2.6/site-packages/indico-0.98_dev-py2.6.egg/MaKaC/webinterface/rh/roomBooking.py", line 118, in _checkParamsRepeatingPeriod\n    raise NoReportError(_("The Start Time must be of the form HH:MM and must be a valid time."))\n', 'NoReportError: The Start Time must be of the form HH:MM and must be a valid time.\n']
{'origin': 'https://indico.cern.ch/roomBooking.py/mapOfRoomsWidget', 'params': {'eYear': '2011', 'repeatability': 'None', 'location': 'CERN', 'sYear': '2011', 'sTime': '14.30', 'eDay': '20', 'eTime': '16.30', 'eMonth': '6', 'sMonth': '6', 'sDay': '20'}, 'method': 'roomBooking.rooms.availabilitySearch'}

[Adrian Moennich <jerome.ernst.monnich@…>]

In [d7131fb68ead599b55764e674fbd5374d87fb47d/indico]:

[FIX] Correctly handle NoReportError? in services

• if a service calls something in the indico core which raises MaKaC.errors.NoReportError? it was not treated as a NoReportError? allowing people to report those errors
• now those errors are detected and re-raised with the correct class
• fixes #843

[Adrian Moennich <jerome.ernst.monnich@…>]

In [d7131fb68ead599b55764e674fbd5374d87fb47d/indico]:

[FIX] Correctly handle NoReportError? in services

• if a service calls something in the indico core which raises MaKaC.errors.NoReportError? it was not treated as a NoReportError? allowing people to report those errors
• now those errors are detected and re-raised with the correct class
• fixes #843