This is a snapshot of Indico's old Trac site. Any information contained herein is most probably outdated. Access our new GitHub site here.

Opened 4 years ago

Closed 3 years ago

Last modified 3 years ago

#827 closed enhancement (fixed)

Add telephone number to support field

Reported by: jbenito Owned by: arescope
Priority: normal Milestone: v1.0
Component: General Version: 0.98-dev
Keywords: Cc:

Description

Dear,

Could you add in "General Settings" - "Support" also field : "telephone
number"? Now is only e-mail and caption.
To people outside CERN will be useful.

Regards,
Edward Nowak

Change History (13)

comment:1 Changed 3 years ago by arescope

  • Owner set to arescope
  • Status changed from new to assigned

comment:2 Changed 3 years ago by arescope

  • Status changed from assigned to awaiting_merge

comment:3 Changed 3 years ago by pferreir

  • Status changed from awaiting_merge to assigned

I am sending this one back because (after discussing with Jose) we believe the implementation needs to be more general and could be improved.

We should consider perhaps creating a SupportInfo (or something like it) object containing all the support information, instead of keeping adding fields directly to the Conference object.

Maybe tomorrow someone will ask for space for a fax number or an IM contact, and we don't want to pollute the attribute space of the Conference class even more.

A small migration task will be required.

comment:4 Changed 3 years ago by arescope

  • Status changed from assigned to in_work

comment:5 Changed 3 years ago by arescope

  • Status changed from in_work to awaiting_merge

comment:6 Changed 3 years ago by pferreir

Much better, but there is still a little issue.

There is a Support object, so there should be no need to prefix all its attributes with support. i.e. supportEmail should be email, getSupportEmail should be getEmail, etc...

comment:7 Changed 3 years ago by pferreir

  • Status changed from awaiting_merge to assigned

comment:8 Changed 3 years ago by arescope

  • Status changed from assigned to in_work

comment:9 Changed 3 years ago by arescope

  • Status changed from in_work to awaiting_merge

comment:10 Changed 3 years ago by pferreir

  • Status changed from awaiting_merge to merging

comment:11 Changed 3 years ago by Alberto Resco Perez <alberto.resco.perez@…>

  • Resolution set to fixed
  • Status changed from merging to closed

In ddb7505a117265306184cd7bb06daa659c2e78c7/indico:

[IMP] Add support telephone to conferences

  • Created SupportInfo? class in order to have more scalability if we add more fields.
  • Closes #827

comment:12 Changed 3 years ago by Pedro Ferreira <jose.pedro.ferreira@…>

In 804644b3b52630b9c9cfb6d3130465188c63a08c/indico:

[FIX] Bug in getEmail

  • Also moved new class to new namespace;
  • see #827

comment:13 Changed 3 years ago by Pedro Ferreira <jose.pedro.ferreira@…>

In c089ad30ac5d8739cdb4b1a0eb2f6c1c00875811/indico:

[FIX] Properly styled support box

  • Added Icomoon icon font;
  • Modernized a bit conference side menu;
  • Got rid of broken top-menu templates;
  • Moved side menu construction to TPL;
  • see #827
Note: See TracTickets for help on using tickets.