#827 closed enhancement (fixed)
Add telephone number to support field
Reported by: | jbenito | Owned by: | arescope |
---|---|---|---|
Priority: | normal | Milestone: | v1.0 |
Component: | General | Version: | 0.98-dev |
Keywords: | Cc: |
Description
Dear,
Could you add in "General Settings" - "Support" also field : "telephone
number"? Now is only e-mail and caption.
To people outside CERN will be useful.
Regards,
Edward Nowak
Change History (13)
comment:1 Changed 3 years ago by arescope
- Owner set to arescope
- Status changed from new to assigned
comment:2 Changed 3 years ago by arescope
- Status changed from assigned to awaiting_merge
comment:3 Changed 3 years ago by pferreir
- Status changed from awaiting_merge to assigned
comment:4 Changed 3 years ago by arescope
- Status changed from assigned to in_work
comment:5 Changed 3 years ago by arescope
- Status changed from in_work to awaiting_merge
comment:6 Changed 3 years ago by pferreir
Much better, but there is still a little issue.
There is a Support object, so there should be no need to prefix all its attributes with support. i.e. supportEmail should be email, getSupportEmail should be getEmail, etc...
comment:7 Changed 3 years ago by pferreir
- Status changed from awaiting_merge to assigned
comment:8 Changed 3 years ago by arescope
- Status changed from assigned to in_work
comment:9 Changed 3 years ago by arescope
- Status changed from in_work to awaiting_merge
comment:10 Changed 3 years ago by pferreir
- Status changed from awaiting_merge to merging
comment:11 Changed 3 years ago by Alberto Resco Perez <alberto.resco.perez@…>
- Resolution set to fixed
- Status changed from merging to closed
comment:12 Changed 3 years ago by Pedro Ferreira <jose.pedro.ferreira@…>
comment:13 Changed 3 years ago by Pedro Ferreira <jose.pedro.ferreira@…>
Note: See
TracTickets for help on using
tickets.
I am sending this one back because (after discussing with Jose) we believe the implementation needs to be more general and could be improved.
We should consider perhaps creating a SupportInfo (or something like it) object containing all the support information, instead of keeping adding fields directly to the Conference object.
Maybe tomorrow someone will ask for space for a fax number or an IM contact, and we don't want to pollute the attribute space of the Conference class even more.
A small migration task will be required.