This is a snapshot of Indico's old Trac site. Any information contained herein is most probably outdated. Access our new GitHub site here.

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#728 closed defect (fixed)

Remove hardcoded email settings/addresses from roombooking system

Reported by: jmonnich Owned by: jmonnich
Priority: normal Milestone: v0.98.1
Component: Room Booking Version:
Keywords: Cc:

Description 

TEST_VERSION_WARNING = "" #"[This notification considers FAKE event in TEST version of new Indico::CRBS. You can ignore it.]"
EMAIL_FOR_DEBUG_NOTIFICATIONS = ""
EMAIL_FROM_PREFIX = "noreply-"
NOTIFICATION_SUBJECT_PREFIX = ""
EMAIL_FOR_CATCH_ALL_NOTIFICATIONS = ""

Get rid of this and use getNoReplyEmail(returnSupport=True) when a noreply email is needed.
Sending emails to a special email if debug is enabled is useless; when debugging with a live database something like ​fakemail should be used to prevent spamming of users anyway.

Change History (5)

comment:1 Changed 4 years ago by jmonnich

  • Status changed from new to assigned

comment:2 Changed 4 years ago by jmonnich

  • Status changed from assigned to awaiting_merge

comment:3 Changed 4 years ago by pferreir

  • Status changed from awaiting_merge to merging

comment:4 Changed 4 years ago by Adrian Moennich <jerome.ernst.monnich@…>

  • Resolution set to fixed
  • Status changed from merging to closed

In [45a4a3b9bceb31750ade69bf0f25004ee480e038/indico]:

[MIN] Get rid of EMAIL_FROM_PREFIX

  • in favor of MaKaCInfo.getNoReplyEmail
  • fixes #728

comment:5 Changed 4 years ago by Adrian Moennich <jerome.ernst.monnich@…>

In [45a4a3b9bceb31750ade69bf0f25004ee480e038/indico]:

[MIN] Get rid of EMAIL_FROM_PREFIX

  • in favor of MaKaCInfo.getNoReplyEmail
  • fixes #728
Note: See TracTickets for help on using tickets.