This is a snapshot of Indico's old Trac site. Any information contained herein is most probably outdated. Access our new GitHub site here.

Opened 5 years ago

Closed 4 years ago

#687 closed defect (fixed)

Unify TPLs Javascript and remove _GID from TPL and RH in PropToAcc/Rej

Reported by: jbenito Owned by: acastill
Priority: normal Milestone: v0.98.1
Component: General Version: 0.98-dev
Keywords: Cc:

Description

In ConfModAbstractPropToRej?, ConfModAbstractPropToAcc?, TrackAbstractPropToAcc?, TrackAbstractPropToRej? there is the same JS code. It is clear that this must be refactored. For instance, the second double-for-loop can be done inside the JS class RadioButtonSimpleField?.

Remember to remove the usage of _GID to search the radiobuttons from the TPLs and from the RH._checkParams!

Change History (5)

comment:1 Changed 5 years ago by jbenito

Also:

  • add parameter manager to make the questions mandatory.
  • add the previous rating if it is the second time for the same proposal and same user.

comment:2 Changed 5 years ago by jmonnich

FYI, I've added the parametermanager stuff yesterday.

comment:3 Changed 5 years ago by acastill

  • Status changed from new to awaiting_merge

comment:4 Changed 4 years ago by jbenito

  • Status changed from awaiting_merge to merging

comment:5 Changed 4 years ago by jbenito

  • Resolution set to fixed
  • Status changed from merging to closed
Note: See TracTickets for help on using tickets.