#611 closed defect (fixed)
Dialogs are not working in the very last version of Google Chrome
| Reported by: | jbenito | Owned by: | jmonnich |
|---|---|---|---|
| Priority: | normal | Milestone: | v0.97.1 |
| Component: | General | Version: | 0.97.0 |
| Keywords: | Cc: |
Description
both in Linux and Windows 7
Change History (11)
comment:1 Changed 5 years ago by dmartinc
comment:2 Changed 5 years ago by jbenito
- Resolution set to worksforme
- Status changed from new to closed
comment:3 Changed 5 years ago by jmonnich
Looks much like an adblock bug. The .exclusivePopup element has a 0x0 size. Renaming it to something not containing the word "Popup" (tested it with "exclusivePopLayer") did not change anything; your comment that it also occurs if adblock is disabled suggests it being an adblock bug, too.
You might want to file a bug with the adblock developers.
comment:4 Changed 5 years ago by adavid
Same problem here (on Mac OS X): disabling adblock worked wonders.
I would report myself the problem but from the last message I can't figure out heads and tails for a proper bug report with the adblock team. I mean, I am not intimate with the details of Indico.
Can someone provide more details (or a test page where this could be checked by the adblock team) and leave this ticket open (it's not like adblock is a really obscure plugin that no one uses...)?
comment:5 Changed 5 years ago by jbenito
- Resolution worksforme deleted
- Status changed from closed to new
comment:6 Changed 5 years ago by jbenito
- Owner set to jmonnich
- Status changed from new to assigned
comment:7 Changed 5 years ago by jmonnich
Actually it's a jQuery issue (which is used by Adblock).
Hi Adrian, As discussed in IRC, the problem is that AdBlock includes JQuery, and JQuery has an offending line: body.removeChild( div ).style.display = "none"; which is line 1263 of code.jquery.com/jquery-1.5.js . Commenting out this line fixes the problem. Not sure why that line specifically causes the behavior, and it may just be hinting at the actual problem, but this is enough to file a bug report with JQuery team or Chrome team. Please try adding this line to the <head> section: <script src="http://code.jquery.com/jquery-1.5.js"></script> , disable AdBlock, and let me know whether the problem persists. If it does, it's a jQuery problem; if it doesn't, it's probably a Chrome problem. Either way, I'll file the bug report. Thanks, and sorry for the trouble, Michael
The AdBlock? developer will file a ticket with the jQuery/Chrome devs.
comment:8 Changed 5 years ago by jmonnich
- Status changed from assigned to in_merge
comment:9 Changed 5 years ago by Adrian Moennich <jerome.ernst.monnich@…>
- Resolution set to fixed
- Status changed from in_merge to closed
comment:10 Changed 5 years ago by adavid
This might be the wrong place to ask, but when would this be pushed into production at CERN?
I'm really sorry... after Jose told me you could not reproduce, i tried disabling my extensions.
It seems that the Adblock extension for Chrome ( https://chrome.google.com/extensions/detail/gighmmpiobklfepjocnamgkkbiglidom ) is causing this.
Adding indico.cern.ch to the whitelist, or "pausing" it still makes the dialogs not work.
Only disabling or removing the extension from the Chrome control panel seems to do the trick.
So... you don't need to lose time on this, at least not for me... although maybe there are other people using Indico with Adblock on Chrome as well...
Cheers,
David