This is a snapshot of Indico's old Trac site. Any information contained herein is most probably outdated. Access our new GitHub site here.

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#559 closed defect (fixed)

Color customisation for conference header doesn't work

Reported by: roel Owned by: lsyroka
Priority: low Milestone: v0.97.0
Component: General Version: 0.97.0
Keywords: Cc:

Description

From confModifDisplay.py/custom?confId=XXX, under Color customization: There seems to be an off-by-one error in the call to colorSelect.py.

The Conference header text color popup has the following URL but pastes the chosen colour in the background colour box:

colorSelect.py?colorCodeTarget=colorCode&colorPreviewTarget=colorpreview&formId=3

The Conference header background color popup looks like this and generates a Javascript error when a colour is clicked:

colorSelect.py?colorCodeTarget=colorCode&colorPreviewTarget=colorpreview&formId=4

window.opener.document.forms[4].colorCode is undefined window.opener.document.forms[4].colorCode.value = val;

One can still just type the colour in the text box, of course.

Change History (5)

comment:1 Changed 5 years ago by jbenito

  • Milestone set to v0.97

comment:2 Changed 5 years ago by lsyroka

  • Owner set to lsyroka
  • Status changed from new to assigned

comment:3 Changed 5 years ago by lsyroka

  • Status changed from assigned to in_merge

comment:4 Changed 5 years ago by Leszek Syroka <leszek.marek.syroka@…>

  • Resolution set to fixed
  • Status changed from in_merge to closed

In [408dbdf8f839f453eec80bfd0a9dee50b8720274]:

[FIX] Color customization for conferences

  • forms in color selector were fetched by index which cause problems at some browsers. Now they are fetched by a form id.
  • fix#559

comment:5 Changed 5 years ago by Leszek Syroka <leszek.marek.syroka@…>

In [408dbdf8f839f453eec80bfd0a9dee50b8720274]:

[FIX] Color customization for conferences

  • forms in color selector were fetched by index which cause problems at some browsers. Now they are fetched by a form id.
  • fix#559
Note: See TracTickets for help on using tickets.