This is a snapshot of Indico's old Trac site. Any information contained herein is most probably outdated. Access our new GitHub site here.

Opened 6 years ago

Closed 6 years ago

Last modified 5 years ago

#321 closed defect (fixed)

Javascript error on alert popups

Reported by: dmartinc Owned by: dmartinc
Priority: low Milestone:
Component: General Version: 0.97.0
Keywords: Cc:

Description

When a "noReportError" is returned by the server, the ErrorReportDialog dialog JS class's draw method calls its _drawWarning method, which in turns constructs and opens an AlertPopup.

However the "draw" method does not return anything and when ErrorReportDialog's postDraw() is called there is a JS error (although the AlertPopup opens fine).

Change History (3)

comment:1 Changed 6 years ago by dmartinc

  • Owner set to dmartinc
  • Status changed from new to accepted

comment:2 Changed 6 years ago by david.martin.clavo@…

  • Resolution set to fixed
  • Status changed from accepted to closed

commit f84b56c293534a0fe93d5045b859d81ccf87cb27
Author: David Martín Clavo <david.martin.clavo@…>
Date: Thu Mar 18 13:54:57 2010 +0100

[FIX] JS error on noErrorReport popups


  • fixes #321
  • _drawWarning no longer calls another Popup but properly returns content.
  • also fixed the margin / paddings in the warning and error variants of ErrorReportDialog? (paddint of 10 px on the all sides).
  • reviewed by jbenito: removed _adjustContentWrapper repetition

comment:3 Changed 5 years ago by David Martín Clavo <david.martin.clavo@…>

In [f84b56c293534a0fe93d5045b859d81ccf87cb27]:

[FIX] JS error on noErrorReport popups

  • fixes #321
  • _drawWarning no longer calls another Popup but properly returns content.
  • also fixed the margin / paddings in the warning and error variants of ErrorReportDialog? (paddint of 10 px on the all sides).
  • reviewed by jbenito: removed _adjustContentWrapper repetition
Note: See TracTickets for help on using tickets.