Subcontribution add presenter from favourites triggers exception

[dmartinc]

When creating a new subcontribution, e.g.

​http://indico.cern.ch/contributionModifSubCont.py?contribId=0&sessionId=0&confId=38692 and press "add sub contribution"

If the logged in user has favourites, he selects one of them as presenter, and clicks the "Choose" button, the following exception happens:

2010-03-12 11:47:01,283 indico.requestHandler - ERROR base.py:325

Request 46912744313680 failed: "__init__() takes at least 4 arguments (2 given)"

url: http://indico.cern.ch/confModifSchedule.py/newContrib?contribId=0&sessionId=0&confId=38692

parameters: {'durationMinutes': '15', 'description': '', 'title': '', 'durationHours': '0', 'slotId': '', 'contribId': '0', 'sessionId': '0', 'keywords': '', 'presenterChosen': '847', 'performedAction': 'Add as presenter', 'orginURL': <MaKaC.common.url.URL instance at 0x2aaac17c7950>, 'confId': '38692'}

Traceback (most recent call last):
  File "/usr/lib/python2.4/site-packages/cds_indico-0.97b2-py2.4.egg/MaKaC/webinterface/rh/base.py", line 476, in process
    res = self._process()
  File "/usr/lib/python2.4/site-packages/cds_indico-0.97b2-py2.4.egg/MaKaC/webinterface/rh/conferenceModif.py", line 5412, in _process
    p = sessions.WPModScheduleNewContrib( self, self._session, self._targetDay )
  File "/usr/lib/python2.4/site-packages/cds_indico-0.97b2-py2.4.egg/MaKaC/webinterface/pages/sessions.py", line 2022, in __init__
    WPModScheduleNewContribBase.__init__(self, targetDay)
TypeError: __init__() takes at least 4 arguments (2 given)

[dmartinc]

The exception in the ticket description seems to only happen if the contribution is inside a session.

If the contribution is in the top-level timetable, an exception is not triggered; instead, the user is redirected to a contribution creation page, e.g. ​http://indico.cern.ch/confModifSchedule.py/newContrib?contribId=3&confId=38692 . The user then mistakes this for the subcontribution creation page and gets another exception, such as:

exception message =>  The starting date for the contribution is not complete, please fill all the fields.
exception type =>  MaKaC.errors.MaKaCError
traceback =>
   File "/usr/lib/python2.4/site-packages/cds_indico-0.97b2-py2.4.egg/MaKaC/webinterface/rh/base.py", line 491, in process
     res = self._processError(e)
   File "/usr/lib/python2.4/site-packages/cds_indico-0.97b2-py2.4.egg/MaKaC/webinterface/rh/base.py", line 284, in _processError
     raise ex

[leszek.marek.syroka@…]

commit 07bd34117771999c6747c6e2017ecdbfb3fc4d09
Author: Leszek Syroka <leszek.marek.syroka@…>
Date: Thu Mar 18 11:58:59 2010 +0100

[FIX] Choosing presenter from favourites

• presenters can be chosen from user's favourites list\
• problem of choosing user at the contribution inside a session was solved
• fix#309
• reviewed by jbenito: removed no needed loops.

[Leszek Syroka <leszek.marek.syroka@…>]

In [07bd34117771999c6747c6e2017ecdbfb3fc4d09]:

[FIX] Choosing presenter from favourites

• presenters can be chosen from user's favourites list\
• problem of choosing user at the contribution inside a session was solved
• fix#309
• reviewed by jbenito: removed no needed loops.