This is a snapshot of Indico's old Trac site. Any information contained herein is most probably outdated. Access our new GitHub site here.

Opened 6 years ago

Closed 5 years ago

Last modified 5 years ago

#231 closed defect (fixed)

Enable 0-min breaks

Reported by: dmartinc Owned by: pferreir
Priority: high Milestone: v0.98.1
Component: Timetable Version: 0.97.0
Keywords: break, timetable Cc:

Description

With 0.96, it was possible to add 0 duration breaks to a timetable. Some users (e.g. Atlas) used this to insert "separators" in the timetable or to strongly mark the end of a day.

However in 0.97 the break creation dialog does not allow a duration of 0.

We should also be careful on how these breaks are displayed in the event display page; we should only show the start date (since the end date is the same).

Change History (10)

comment:1 Changed 5 years ago by jbenito

  • Priority changed from normal to high

comment:2 Changed 5 years ago by jbenito

Same as #438

comment:3 Changed 5 years ago by jbenito

Up to now, users where using 0 minutes Breaks in order to add notes or comments in the timetable.
Instead we should provide another entry type like "note" or "comment" with a starting time but without duration.

comment:4 Changed 5 years ago by jmonnich

  • Owner set to jmonnich
  • Status changed from new to assigned

comment:5 Changed 5 years ago by jmonnich

  • Status changed from assigned to in_merge

comment:6 Changed 5 years ago by pferreir

The solution is far from optimal, since zero-sized breaks cannot practically not be moved around. This feature will end up causing more problems than benefits.

I would prefer spending some more time in adding an extra layer of "annotations" to the timetable (maybe when we refactor it for drag'n'drop)?

comment:7 Changed 5 years ago by pferreir

  • Status changed from in_merge to assigned

Ok, since this is needed for 0.98, I will send it back. The current problems are:

  • Arrows don't work OK, probably due to duration zero;
  • Doing a move that keeps size 0 has absolutely no effect;

Adrian, could you give it a second look?

comment:8 Changed 5 years ago by pferreir

  • Owner changed from jmonnich to pferreir

comment:9 Changed 5 years ago by Adrian Moennich <jerome.ernst.monnich@…>

  • Resolution set to fixed
  • Status changed from assigned to closed

In [4376e4bdec587fe335958c3f61811d53009280d4/indico]:

[IMP] Allow 0-minute breaks

comment:10 Changed 5 years ago by Pedro Ferreira <jose.pedro.ferreira@…>

In [64824a4fe8140c7697d57c5f47d43da97e9964a4/indico]:

[FIX] Some fixes over Adrian's patch

  • Zero-sized breaks can now be moved both by time change or using the arrows;
  • Fixed the problem that silently closed the edit balloon without error;
  • Disabled zero-sized contributions, etc... in the interface;
  • Closes #231 for good (I hope);
  • Fixed some issues with request listener parameters;
Note: See TracTickets for help on using tickets.