This is a snapshot of Indico's old Trac site. Any information contained herein is most probably outdated. Access our new GitHub site here.

Opened 6 years ago

Closed 6 years ago

Last modified 5 years ago

#168 closed defect (fixed)

getFormValues Javascript problem

Reported by: dmartinc Owned by: dmartinc
Priority: low Milestone: v0.97.0
Component: General Version: 0.97.0
Keywords: Cc:

Description

The getFormValues javascript function, which scans a list of <input> (and similar) elements and builds a dictionary with the values, generates an empty key if one of the elements has no name.

Example:
<input name="title"></input>
<input></input>

If the user has written "Reunion" in the first and "Important" in the second, the returned dictionary will be:
{"title":"Reunion", "":"Important"}

Change History (6)

comment:1 Changed 6 years ago by pferreir

  • Milestone set to v0.97

comment:2 Changed 6 years ago by pferreir

Is this causing problems right now? If this has no influence in the current system behavior, i believe there shouldn't be a ticket.

comment:3 Changed 6 years ago by dmartinc

It isn't because in the existing Collaboration plugins (EVO, CERNMCU, RecReq?, WebReq?) there are no <input> elements without a "name" attribute; there may be one in Vidyo, though.
Afaik only the Collaboration core makes use of this getFormValues function.
So all in all, I think it's ok if you set the milestone to v0.98 :)

comment:4 Changed 6 years ago by dmartinc

  • Status changed from new to accepted

comment:5 Changed 6 years ago by david.martin.clavo@…

  • Resolution set to fixed
  • Status changed from accepted to closed

commit d66f128bfdd86fa980e2ca56c60dd086b89eaea6
Author: David Martín Clavo <david.martin.clavo@…>
Date: Fri Jan 29 15:59:40 2010 +0100

[FIX] getFormValues fix


-The getFormValues JS function was adding values
to the returned object even when the input
elements had no name.
-fixes #168

comment:3 Changed 5 years ago by David Martín Clavo <david.martin.clavo@…>

In [d66f128bfdd86fa980e2ca56c60dd086b89eaea6]:

[FIX] getFormValues fix

-The getFormValues JS function was adding values
to the returned object even when the input
elements had no name.
-fixes #168

Note: See TracTickets for help on using tickets.