This is a snapshot of Indico's old Trac site. Any information contained herein is most probably outdated. Access our new GitHub site here.

Opened 2 years ago

Closed 23 months ago

#1383 closed defect (fixed)

Spacer in menu does not appear in HTML

Reported by: hoffmann Owned by: ferhatelmas
Priority: normal Milestone: v1.2
Component: General Version: 1.1
Keywords: Cc:

Description

We have tried to insert two "spacers" in the menu of ​https://indico.cern.ch/conferenceDisplay.py?confId=269618, one disabled, one enabled, to cross-check, if there was a simple bug with logic inversion ;-)
Well, the problem is that it does not seem to appear in the HTML output for the menu. I see

<li class="menuConfTitle" id="menuLink_XXX">

and

<li class="menuConfTitle" id="menuLink_YYY">

seamlessly attached after one after the other.
Any chance to patch this quickly?

Change History (4)

comment:1 Changed 2 years ago by ferhatelmas

  • Owner set to ferhatelmas
  • Status changed from new to assigned 
% if type in ["system", "extern"] and index != -1:
    <li class="spacer"></li>
% endif

Bug explained here is related to first case of if. Moreover, we can currently add a spacer to the end so why not in the front? which means second case of if is also unnecessary. Fix seems to be getting rid of if at all.

comment:2 Changed 2 years ago by ferhatelmas

  • Status changed from assigned to awaiting_merge

comment:3 Changed 23 months ago by jbenito

  • Status changed from awaiting_merge to merging

comment:4 Changed 23 months ago by Jose Benito <jose.benito.gonzalez@…>

  • Resolution set to fixed
  • Status changed from merging to closed

In 4a475c9b3d13f3e3ffee32aa021fc6fb531879b1/indico:

[FIX] Double Spacers in Event Left Menu

closes #1383

Note: See TracTickets for help on using tickets.