This is a snapshot of Indico's old Trac site. Any information contained herein is most probably outdated. Access our new GitHub site here.

Opened 2 years ago

Closed 2 years ago

#1247 closed defect (fixed)

Do not let people select rooms they can't book

Reported by: pferreir Owned by: aavilesd
Priority: high Milestone: v1.1
Component: Room Booking Version: 1.0
Keywords: Cc:

Description

In the new Room Booking interface, one is shown a row per room with a green bar representing "bookable" times. However, it can happen that you click on a bar and get a page saying "You are not authorized to book this room", as you are not member of the group that can book this room. This should not happen.

There are two options:

  • When a user clicks a "green bar", do an AJAX call that checks if (s)he can book that room, and only forward him/her to the booking page in case (s)he's got permission. Otherwise, show a message stating which group has access.
  • Do not even show that room as bookable from the beginning. Display the bar in a different color or something like that (probably slower?).

Change History (5)

comment:1 Changed 2 years ago by aavilesd

  • Owner set to aavilesd
  • Status changed from new to assigned

comment:2 Changed 2 years ago by aavilesd

  • Status changed from assigned to in_work

comment:3 Changed 2 years ago by aavilesd

  • Status changed from in_work to awaiting_merge

Pushed to ​https://github.com/OmeGak/indico/tree/1247-protected-rooms-booking

comment:4 Changed 2 years ago by jbenito

  • Status changed from awaiting_merge to merging

comment:5 Changed 2 years ago by jbenito

  • Resolution set to fixed
  • Status changed from merging to closed
Note: See TracTickets for help on using tickets.