This is a snapshot of Indico's old Trac site. Any information contained herein is most probably outdated. Access our new GitHub site here.

Opened 3 years ago

Closed 3 years ago

#1217 closed defect (fixed)

change executeonload for jquery.ready

Reported by: arescope Owned by: arescope
Priority: normal Milestone: v1.0
Component: General Version: 0.99
Keywords: Cc:

Description

Some code is not working when the statistics are down, because the document is not loaded at all. With jquery.ready, the code is executed when the DOM is loaded. We can avoid that blocking issue.

Change History (4)

comment:1 Changed 3 years ago by arescope

  • Owner set to arescope
  • Status changed from new to assigned

comment:2 Changed 3 years ago by arescope

  • Status changed from assigned to in_work

comment:3 Changed 3 years ago by arescope

  • Status changed from in_work to awaiting_merge

comment:4 Changed 3 years ago by Jose Benito <jose.benito.gonzalez@…>

  • Resolution set to fixed
  • Status changed from awaiting_merge to closed

In dbeed83833c61f4308c3c92a64d54a500d14631d/indico:

[FIX] Change window.onload to jquery.ready

  • When we put IndicoUI.executeOnload it was executing that code when window.load but if some js is broken, the page does not work.
  • With jQuery.ready we wait to get the DOM loaded but not to all the page, so the page is not blocked.
  • Closes #1217
Note: See TracTickets for help on using tickets.