Opened 3 years ago
Closed 3 years ago
#1072 closed defect (fixed)
Protection - show protected children elements
Reported by: | arescope | Owned by: | arescope |
---|---|---|---|
Priority: | normal | Milestone: | v1.0 |
Component: | General | Version: | |
Keywords: | Cc: |
Description (last modified by pferreir)
If the conference is public but has protected contributions, these should be properly indicated (by means of a qtip, for instance).
Change History (21)
comment:1 Changed 3 years ago by arescope
- Owner set to arescope
- Status changed from new to assigned
comment:2 Changed 3 years ago by arescope
- Status changed from assigned to awaiting_merge
comment:3 Changed 3 years ago by jbenito
- Status changed from awaiting_merge to merging
comment:4 Changed 3 years ago by jbenito
- Status changed from merging to assigned
comment:5 Changed 3 years ago by arescope
- Status changed from assigned to awaiting_merge
comment:6 Changed 3 years ago by jbenito
- Milestone changed from v0.99.0 to v1.0
comment:7 Changed 3 years ago by pferreir
- Status changed from awaiting_merge to merging
comment:8 Changed 3 years ago by pferreir
- Description modified (diff)
- Summary changed from Protection show protected children elements to Protection - show protected children elements
comment:9 Changed 3 years ago by pferreir
comment:10 Changed 3 years ago by pferreir
- Status changed from merging to assigned
comment:11 Changed 3 years ago by arescope
- Status changed from assigned to in_work
comment:12 Changed 3 years ago by arescope
- Status changed from in_work to awaiting_merge
comment:13 Changed 3 years ago by arescope
- Status changed from awaiting_merge to infoneeded
comment:14 Changed 3 years ago by arescope
- Status changed from infoneeded to assigned
comment:15 Changed 3 years ago by arescope
- Status changed from assigned to in_work
comment:16 Changed 3 years ago by arescope
- Status changed from in_work to awaiting_merge
comment:17 Changed 3 years ago by arescope
- Status changed from awaiting_merge to assigned
comment:18 Changed 3 years ago by arescope
- Status changed from assigned to in_work
comment:19 Changed 3 years ago by jbenito
- Status changed from in_work to awaiting_merge
comment:20 Changed 3 years ago by jbenito
- Status changed from awaiting_merge to merging
comment:21 Changed 3 years ago by jbenito
- Resolution set to fixed
- Status changed from merging to closed
Note: See
TracTickets for help on using
tickets.
The amount of code in the last commit is just overwhelming. I think it's clear we need a change of strategy here, otherwise we'll end up having 5 or 6 methods per type of object that basically do the same thing in different ways.
In my public repo, you can find everything up to the one but last commit, with some changes. I've made it look (I think) a bit nicer, but it's still lacking the display of public elements inside private events, as implemented by the last commit.
Me and Jose had a short discussion on the strategy to follow and the best idea we could get to was an O(1) structure (BTree, TreeSet?, dictionary, etc..) containing all the elements inside the event that do not follow the standard inheritance rule (they're "exceptions"). This could be then used to directly retrieve the elements that don't have a "predictable" protection status. This would have to be updated whenever setProtection() is called.