Team: the alerts should be Indico style dialogs, not JS confirm()

[pferreir]

I've fixed:

• cosa variables lying around
• Broken "Modification key" option
• Broken "protection" page (from a previous commit);

Available as pferreir-public/194-review.

However, there's a common pattern (confirm dialog after clicking on link) that could be better addressed.
Currently it's being done like this:

    $(".deleteAlarm").click(function(){
        var self = this;
        new ConfirmPopup($T("Delete alarm"), $T("Are you sure to delete this alarm?"), function(confirmed){
            if(confirmed){
                window.location = self.getAttribute("href");
            }
        }).open();
        return false;
    });

What about a more general approach which allows us to set a data attribute such as:

<a href="http://target/url" data-confirm="Really delete this?">Delete</a>

This would basically consist of a general version of the code above without having to repeat it. The only challenge would be finding the right place where to execute the selector (after page load).

[Alberto Resco Perez <alberto.resco.perez@…>]

In 0d0df3ac543cf19e066d40e237cd873a0d4afe6a/indico:

[IMP] Remove js popups

• Replace alert by AlertPopup?.
• Replace confirm by ConfirmPopup?.
• Closes #194.

[Alberto Resco Perez <alberto.resco.perez@…>]

In e4c811bca4d1238e154aff1e0d3515105c4c16c9/indico:

[IMP] ConfirmPopup? with link template.

• Refactor and reuse of code.
• See #194.