This is a snapshot of Indico's old Trac site. Any information contained herein is most probably outdated. Access our new GitHub site here.

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#1018 closed enhancement (fixed)

Download files through HTTP API

Reported by: jbenito Owned by: jatrzask
Priority: normal Milestone: v1.0
Component: General Version: 0.98-dev
Keywords: Cc:

Description


Change History (15)

comment:1 Changed 3 years ago by jbenito

  • Milestone changed from v0.99.1 to v0.99.0

comment:2 Changed 3 years ago by jbenito

Is it secure? shall we do this?

comment:3 Changed 3 years ago by jatrzask

  • Owner set to jatrzask
  • Status changed from new to assigned

comment:4 Changed 3 years ago by jatrzask

  • Status changed from assigned to in_work

comment:5 Changed 3 years ago by jatrzask

  • Status changed from in_work to awaiting_merge

comment:6 Changed 3 years ago by pferreir

  • Milestone changed from v0.99.0 to v1.0

comment:7 Changed 3 years ago by pferreir

I noticed the current URL syntax is /contribution/session, while, logically, it should be /session/contribution (contributions are inside sessions and not the other way round).

The URL example in the comments in FileHook seems to be outdated.
It would also be worth adding a reference to the meaning of TYPE in file.rst.

As for the URL format, maybe we coud omit the res part, as it is impossible to download a material without specifying the resource anyway, and even if it weren't, materials can only contain resources.

Otherwise, everything seems fine.

Last edited 3 years ago by pferreir (previous) (diff)

comment:8 Changed 3 years ago by pferreir

  • Status changed from awaiting_merge to assigned

comment:9 Changed 3 years ago by jatrzask

  • Status changed from assigned to in_work

comment:10 Changed 3 years ago by jatrzask

  • Status changed from in_work to awaiting_merge

comment:11 Changed 3 years ago by pferreir

  • Status changed from awaiting_merge to merging

comment:12 Changed 3 years ago by Jakub Trzaskoma <jakub.piotr.trzaskoma@…>

  • Resolution set to fixed
  • Status changed from merging to closed

In 381a8d1c5e3cc9e9b4773eb5849b91283779052a/indico:

[IMP] Added docs for file download HTTP API

  • add file.py common for RH and HTTP API
  • closes #1018

comment:13 Changed 3 years ago by Jakub Trzaskoma <jakub.piotr.trzaskoma@…>

In 04d2a3f01e74c5002e3379ec410d66e47f0474c1/indico:

[FIX] Small HTTPfile API fixes

  • small changes in url params
  • changed time name from 'file' to 'bin'
  • fixed and updated docs
  • closes #1018

comment:14 Changed 3 years ago by Pedro Ferreira <jose.pedro.ferreira@…>

In a091782c6edd101b6be639f6dbbfe39380e2202a/indico:

[IMP] Moved file download code to file.py

  • Better feature separation;
  • Simplified a bit file download code;
  • See #1018;

comment:15 Changed 3 years ago by Pedro Ferreira <jose.pedro.ferreira@…>

In d2ae703ffef9dd1c0b3aa611f5d936d96b002d07/indico:

[IMP] Refactored HTTP API serialization mechanism

  • In order to allow greater flexibility in output formats;
  • Serializers can now set HTTP header parameters;
  • Moved serializers to HTTP API, since they are becoming too HTTP-specific;
  • Allowed HTTP API Hooks to disable caching on demand;
  • see #1018
Note: See TracTickets for help on using tickets.